Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer fails after lookoutd deployment #509

Open
smacker opened this issue Dec 27, 2018 · 6 comments
Open

Analyzer fails after lookoutd deployment #509

smacker opened this issue Dec 27, 2018 · 6 comments

Comments

@smacker
Copy link
Contributor

smacker commented Dec 27, 2018

Looks like style-analyzer keeps an open connection to lookoutd.
When we redeploy lookout it obviously gets broken.

gRPC reestablishes connection automatically but only after the second request to the analyzer.
So the first Review/Push request after restart fails.

Please don't fix it yet. We might want to fix it in lookout-sdk (in the connection helper).

@zurk
Copy link
Contributor

zurk commented Dec 27, 2018

related issue: src-d/charts#128
My bad. It is unrelated.

@smacker
Copy link
Contributor Author

smacker commented Dec 27, 2018

huh? How is it related?

@vmarkovtsev
Copy link
Collaborator

@smacker Is it an open connection from lookoutd to analyzer (events channel) or from analyzer to lookoutd (data service)?

@smacker
Copy link
Contributor Author

smacker commented Jan 8, 2019

From analyzer to lookoutd (data service).

@smacker
Copy link
Contributor Author

smacker commented Jan 10, 2019

Please update grpcio to the recent version in your analyzer to fix the issue.
You will need to use sdk v0.3.0+ for that.

@vmarkovtsev
Copy link
Collaborator

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants