Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylinders in URDF are parsed as Capsule #423

Closed
jmirabel opened this issue Dec 5, 2017 · 7 comments
Closed

Cylinders in URDF are parsed as Capsule #423

jmirabel opened this issue Dec 5, 2017 · 7 comments

Comments

@jmirabel
Copy link
Contributor

jmirabel commented Dec 5, 2017

When encountering tag cylinder in URDF, pinocchio parser builds a fcl::Capsule. The reason for this is that URDF does not support capsules (and it does not seem it will: ros/urdfdom_headers#24).

I see several way to handle this:

  1. use a negative radius and or length to specify that a cylinder should be a capsule,
  2. add an attribute or a tag below tag cylinder in the URDF and parse it with pinocchio,
  3. use the tag collision_checking mentioned at the bottom of this page,
  4. do not support capsule.

I can work on this. Any preference on the method ?

@jcarpent
Copy link
Contributor

jcarpent commented Dec 5, 2017

I think

  1. is the shortest path to handle your particular cases
    BUT
  2. might be investigated as a long term solution as we will be able to handle new features that are not provided by URDF yet.

@jcarpent
Copy link
Contributor

jcarpent commented Dec 5, 2017

In conclusion, I would go for the second solution.

@olivier-stasse
Copy link
Member

As the capsule are mostly used for doing collision checking and that this is ignored by the URDF parser why @jcarpent do you prefer 2 over 3 ?

@jcarpent
Copy link
Contributor

jcarpent commented Dec 5, 2017

Just be because in the two scenarios, we will need to add an additional parsing stage. So you're right, 2. and 3. are equivalent, except we can give precise naming with the second option.

@olivier-stasse
Copy link
Member

yes but if we use 3 and if the block checking_collision is ignored we could use directly capsule in place of cylinder which to me looks more readable.

@jmirabel
Copy link
Contributor Author

jmirabel commented Dec 5, 2017

According to the discussion, I chose solution 3.

@jcarpent
Copy link
Contributor

jcarpent commented Dec 5, 2017

Solved by #425.

@jcarpent jcarpent closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants