-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cylinders in URDF are parsed as Capsule #423
Comments
I think
|
In conclusion, I would go for the second solution. |
As the capsule are mostly used for doing collision checking and that this is ignored by the URDF parser why @jcarpent do you prefer 2 over 3 ? |
Just be because in the two scenarios, we will need to add an additional parsing stage. So you're right, 2. and 3. are equivalent, except we can give precise naming with the second option. |
yes but if we use 3 and if the block checking_collision is ignored we could use directly capsule in place of cylinder which to me looks more readable. |
According to the discussion, I chose solution 3. |
Solved by #425. |
When encountering tag cylinder in URDF, pinocchio parser builds a
fcl::Capsule
. The reason for this is that URDF does not support capsules (and it does not seem it will: ros/urdfdom_headers#24).I see several way to handle this:
cylinder
in the URDF and parse it with pinocchio,collision_checking
mentioned at the bottom of this page,I can work on this. Any preference on the method ?
The text was updated successfully, but these errors were encountered: