Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Regular Expression Conversion Problem with the Rules Converter #29

Open
x1angli opened this issue Mar 17, 2017 · 0 comments
Open

Regular Expression Conversion Problem with the Rules Converter #29

x1angli opened this issue Mar 17, 2017 · 0 comments

Comments

@x1angli
Copy link

x1angli commented Mar 17, 2017

Thanks for this wonderful tool.

I found a minor issue when using The Rules Converter. Say if I have a dnsmasq conf file written like
server=/.blogspot.com/8.8.8.8

it means I want blogspot.com along with its subdomains to be resolved by 8.8.8.8.

The correct conversion should be sth like
[ { "Pattern": "^(.*\\.)?blogspot\\.com$", "NameServer": "8.8.8.8" } ]

However, the current converter adds extra '\\.' in the URL, yielding
[ { "Pattern": "^(.*\\.)?\\.blogspot\\.com$", "NameServer": "8.8.8.8" } ]
so that the rule won't work as expected.

The converter might deal with such edge case more properly. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant