Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage in parts of Minder with low coverage. #4380

Open
dmjb opened this issue Sep 5, 2024 · 0 comments
Open

Improve test coverage in parts of Minder with low coverage. #4380

dmjb opened this issue Sep 5, 2024 · 0 comments
Assignees
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@dmjb
Copy link
Contributor

dmjb commented Sep 5, 2024

Certain parts of Minder have low unit test coverage. In at least one recent incident, the incident could have been prevented if there had been some unit test coverage of the codepath in question (there was none).

Based on some recent pain points, and looking at stats from Coveralls, some of the files we should focus attention our attention on are:

  1. internal/providers/github/common.go
  2. internal/controlplane/handlers_profile.go
  3. internal/controlplane/handlers_evalstatus.go
  4. internal/verifier/sigstore/container/container.go
  5. internal/util/helpers.go
  6. internal/controlplane/handlers_projects.go
  7. internal/controlplane/handlers_user.go
  8. internal/controlplane/handlers_oauth.go
  9. ...tions/alert/security_advisory/security_advisory.go
  10. internal/controlplane/handlers_artifacts.go
@blkt blkt added the P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Development

No branches or pull requests

3 participants