-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summary with one line per _named_ parameter #43
Comments
One possibility is something like what I put below (I think @andrewgelman and @avehtari and I discussed something like this one time when Aki was visiting). Not sure which columns we include, but a concise table like this would be a really nice option for models with many parameters: variable min_mean max_mean max_rhat min_ess_bulk min_ess_tail
alpha[1] 4.5 4.5 1.0 881 300
tau[1] 3.8 3.8 1.1 386 311
omega[9] 1.5 7.4 1.0 552 272
Sigma[7,7] -1.7 5.1 1.0 421 202 Here the numbers inside brackets indicate the dimensions (we could also omit if a scalar instead of putting @andrewgelman Did we end up coming up with a better idea than putting the dimensions in brackets? Anyone else have any thoughts on this? |
Since brackets are used for indexing, this can cause confusion for R users. Would it be too much to have a column
|
dim separately may be a little ugly and not not too helpful for filtering I would say as the structure would vary across variables, that is, sometimes 1 number sometimes 2 or more separated with commas. |
What if we just replace the brackets to a different symbol to refer to dimension? There are lots of possibilities. Here are just a few:
|
@paul-buerkner I'm not sure I understand the filtering issue with dim in a separate column --- it seems to me it would be easier to filter if dims were not a part of the |
@mjskay you have a good point there. Not sure how to best represent the dimension, but you are right that filtering after variable should be easily possible. |
If we're gonna do one of these, I'd prefer the parentheses, as the braces look weird to me and the angle brackets make me thing of upper and lower. But if we're going to do it this way, what about indicating this in the header, thus:
variable (dims) min_mean max_mean max_rhat min_ess_bulk min_ess_tail
A
… On Nov 13, 2019, at 11:34 AM, Jonah Gabry ***@***.***> wrote:
What if we just replace the brackets to a different symbol to refer to dimension? There are lots of possibilities. Here are just a few:
variable min_mean max_mean max_rhat min_ess_bulk min_ess_tail
alpha (1) 4.5 4.5 1.0 881 300
tau (1) 3.8 3.8 1.1 386 311
omega (9) 1.5 7.4 1.0 552 272
Sigma (7,7) -1.7 5.1 1.0 421 202
variable min_mean max_mean max_rhat min_ess_bulk min_ess_tail
alpha {1} 4.5 4.5 1.0 881 300
tau {1} 3.8 3.8 1.1 386 311
omega {9} 1.5 7.4 1.0 552 272
Sigma {7,7} -1.7 5.1 1.0 421 202
variable min_mean max_mean max_rhat min_ess_bulk min_ess_tail
alpha <1> 4.5 4.5 1.0 881 300
tau <1> 3.8 3.8 1.1 386 311
omega <9> 1.5 7.4 1.0 552 272
Sigma <7,7> -1.7 5.1 1.0 421 202
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#43>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZYCUPJIO2MOH7YPDFUPHLQTQUBFANCNFSM4JKQOFFQ>.
|
Hey guys, I'm still playing with ways to summarize the huge draws array that I'm working with, and realized that this issue is pretty relevant as well. I've approached the problem as below. If the approach looks not-crazy then I could try to clean it up and turn it into a PR. This would involve better error handling, inferring the dimensions of the nonscalar parameters, and wrangling the output into whatever format you want. The default (which is tailored to Stan) is to "roll up" the summaries for any parameter with a Functions:
Example:
|
This looks like it could be very useful to me! Two quick thoughts if we go down this road:
|
The discussion in #32 reminded me that one thing @andrewgelman and others have been wanting for a while (and that I think would also be useful as an alternative to the standard summary output) is a summary where each vector/matrix/array parameter only occupies a single line just like scalars. That is, each line corresponds to a named parameter rather than a parameter element.
(This could be its own thing or just an option to a custom print method for our existing summary objects.)
The quantities to display are debatable (e.g. maybe min of all the individual elements’ ESS, max of the Rhats, etc), so it would be good to get input from Andrew and anyone else interested.
The text was updated successfully, but these errors were encountered: