Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_stan_json and to_stan_json to rstantools? #120

Open
avehtari opened this issue Jan 28, 2024 · 6 comments
Open

write_stan_json and to_stan_json to rstantools? #120

avehtari opened this issue Jan 28, 2024 · 6 comments

Comments

@avehtari
Copy link
Contributor

CmdStanR has write_stan_json(). BridgeStan could use that, too. In addition, BridgeStan would benefit from a to_stan_json() function that would not write to file, but just return a string. I made an issue to bridgestan roualdes/bridgestan#202, but @WardBrian suggested putting it somewhere else, and maybe rstantools would be appropriate?

@jgabry
Copy link
Member

jgabry commented Jan 30, 2024

The only issue I can think of with putting it in rstantools is that then cmdstanr would need to add a dependency on rstantools just to use this one function. @andrjohns what do you think?

@WardBrian
Copy link
Member

in Python I put this in a brand new package I called (creatively) “stanio”

@avehtari
Copy link
Contributor Author

Any further thoughts on this? I'm fine adding to_stan_json() to any package, but we need a decision on where to put it

@WardBrian
Copy link
Member

I think for BridgeStan we would not really be willing to take a dependency on rstan or rstantools. It would be nice if it was in its own small package, or if we want to keep the number of CRAN submissions down, something backend agnostic (posterior? It doesn't quite fit I guess)

@andrjohns
Copy link
Collaborator

I think there's definitely a need for a backend-agnostic package for Stan-related utilities. I'd also be fairly invested in this since it would simplify a bunch of things I want to do for the StanEstimators package, so I'd be fine to take the maintainership for CRAN.

I can join the next Stan gathering meeting and we can chat it through then?

@WardBrian
Copy link
Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants