Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloo generic #55

Open
jgabry opened this issue Apr 17, 2019 · 3 comments
Open

reloo generic #55

jgabry opened this issue Apr 17, 2019 · 3 comments

Comments

@jgabry
Copy link
Member

jgabry commented Apr 17, 2019

@paul-buerkner I'd like to add a generic for reloo so we can have reloo.stanreg and reloo.brmsfit methods. But I see that currently brms takes the first argument of reloo to be the loo object. So it can't change to a brmsfit method without breaking backwards compatibility, right? If that's the case then maybe we should use a different name than reloo for the generic and new methods and you can deprecate reloo it in brms. What do you think? Definitely open to other ideas.

@paul-buerkner
Copy link
Contributor

I could just add a reloo.loo method to brms or we can even add it to loo and then internally do the dispatch based on the second, model object argument. This way, we won't break backwards compatibility but still get the generic going I think.

@avehtari
Copy link
Contributor

Was there resolution for this?

@avehtari
Copy link
Contributor

Bumping this reloo question up again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants