Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint 8 compatibility #192

Closed
Tracked by #230
TrejGun opened this issue Oct 10, 2021 · 18 comments · Fixed by #193
Closed
Tracked by #230

eslint 8 compatibility #192

TrejGun opened this issue Oct 10, 2021 · 18 comments · Fixed by #193
Milestone

Comments

@TrejGun
Copy link

TrejGun commented Oct 10, 2021

Hi guys!

Please tell us if eslint-config-standard is compatible with the new version of ESlint?
and if yes please add it to peerDependencies

@theoludwig theoludwig mentioned this issue Oct 10, 2021
3 tasks
@voxpelli
Copy link
Member

We are actively working towards this, yes! Though we have been a bit short of time lately, will try to get it out as soon as possible. See PR.

@voxpelli
Copy link
Member

Still working on this, see #193 for current status

@meabed
Copy link

meabed commented Nov 21, 2021

Thanks a lot @voxpelli - would this be ready anytime soon? I could help if needed to get it ready.

@voxpelli
Copy link
Member

@meabed We are largely waiting for two of the plugins that we use (eslint-plugin-node and eslint-plugin-promise) to be updated to support ESLint 8, no ETA from the maintainers of those, we're tracking the status of it in #193

Right now I don't think there's much to help with in that regard, but thanks for the offer! 🙏

@JanFellner
Copy link

The dependency eslint-config-node you refer to seems not widely used, it has weekly downloads of 36.104....
Do you really rely on it or would it be possible to drop that dependency?

@voxpelli
Copy link
Member

The dependency eslint-config-node you refer to seems not widely used, it has weekly downloads of 36.104.... Do you really rely on it or would it be possible to drop that dependency?

It's the plugin that we use, it has 3 million weekly downloads: https://www.npmjs.com/package/eslint-plugin-node 🙂

@JanFellner
Copy link

A might got guided into a wrong direction. This PR mentiones the config...
#193 (comment)
"ehmicky mentioned this pull request on 11 Oct "
fix(deps): update dependency eslint to v8 netlify/eslint-config-node#321

@voxpelli
Copy link
Member

@JanFellner It mentions the plugin? Only mention of eslint-config-node there is that they mention in a PR that they are blocked by us before they can upgrade to ESLint 8, as they depend on us: https://github.com/netlify/eslint-config-node/blob/ddd5fb1c482eb6fde48a354e4126a4297c2ddf72/.eslintrc.js#L12

@aladdin-add
Copy link

aladdin-add commented Dec 17, 2021

eslint-plugin-node's latest version v11.1.0 was published ~2y ago. nor sure if it's still maintained, I've asked the author, but no response. :-( 

mysticatea/eslint-plugin-node#300

@voxpelli
Copy link
Member

@aladdin-add If you want help, we could check if we could bring your fork under the Standard organization.

Been pondering that a fork probably would be necessary, great that you got around to do it!

@aladdin-add
Copy link

sure, I'm totally open to transferring to Standard, for better maintainability and discoverability.

@aladdin-add
Copy link

another point: nicholas has a plan to make an org eslint-community. It's also great to go there (yes, eslint is its user too!). I'll talk to him to see what's his suggestion.

@MichaelDeBoey
Copy link

MichaelDeBoey commented Dec 17, 2021

Would be nice if we could transfer repos like eslint-plugin-node, eslint-plugin-es, eslint-utils & @mysticatea/eslint-plugin to a new @eslint-community org

@MichaelDeBoey
Copy link

@xjamundx let me know that eslint-plugin-promise can be added to the new org too

CC/ @aladdin-add @voxpelli

@MichaelDeBoey
Copy link

MichaelDeBoey commented Jan 31, 2022

@aladdin-add @divlo @voxpelli Do we already have some news about the new @eslint-community org and moving eslint-plugin-node, eslint-plugin-es, eslint-utils, @mysticatea/eslint-plugin & eslint-plugin-promise over there?

It would be awesome if we could talk about this on Twitter or Discord or so.
https://twitter.com/MichaelDeBoey93

@voxpelli
Copy link
Member

@MichaelDeBoey Are you in control of @eslint-community? If so, then feel free to add me there and we can have a discussion in a team we set up there?

@MichaelDeBoey
Copy link

@voxpelli I'm not, I thought one of you guys was tbh 🤔

I would like to be added too if possible.

@voxpelli
Copy link
Member

@MichaelDeBoey Lets continue the discussion here: eslint-community/eslint-plugin-n#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants