Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorboard logging breaks if value is of the type "string" #735

Open
mhmaqbool opened this issue Sep 20, 2024 · 2 comments
Open

Tensorboard logging breaks if value is of the type "string" #735

mhmaqbool opened this issue Sep 20, 2024 · 2 comments

Comments

@mhmaqbool
Copy link

I noticed that tensorboard logging causes the code to break when the value happens to be of type string. For example, if throughput/device_kind happens to be a "string", the following code breaks,

def log_summary(self, metrics: dict[str, Any]):
        for k, v in metrics.items():
            self.writer.add_scalar(k, v, global_step=None)
@dlwh
Copy link
Member

dlwh commented Sep 20, 2024

ah thanks for the catch. Any chance I could induce you to put up a PR :-)

@mhmaqbool
Copy link
Author

Definitely. I will be happy to contribute. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants