Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

AccountTransaction should impl From for each one of it's variant #1704

Open
tdelabro opened this issue Mar 21, 2024 · 0 comments
Open

AccountTransaction should impl From for each one of it's variant #1704

tdelabro opened this issue Mar 21, 2024 · 0 comments

Comments

@tdelabro
Copy link
Contributor

Right now if I want to create and Transaction from an InvokeTransaction I have to write this code:

Transaction::AccountTransaction(AccountTransaction::Invoke(transaction))

This is overly verbose.
From<InvokeTransaction> for AccountTransaction and From<InvokeTransaction> for Transaction are easy to implement and will make the code more straightforward.
Same for all other tx types
gswirski pushed a commit to reilabs/blockifier that referenced this issue Jun 26, 2024
@remybar
Sozo call command (starkware-libs#1704)
defc01a 
* typo

* sozo: add call command

add `sozo call` command to be able to directly call view functions without using
`starkli`.

* add sozo call tests

* fix fmt

* add block-id option to call command
@tdelabro tdelabro mentioned this issue Jul 31, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: impl From AccountTransaction variants for Transaction tdelabro/sequencer
1 participant
@tdelabro