Skip to content

Latest commit

 

History

History
20 lines (13 loc) · 1.18 KB

CONTRIBUTING.md

File metadata and controls

20 lines (13 loc) · 1.18 KB

CONTRIBUTING

Contributions are welcome, and are accepted via pull requests. Please review these guidelines before submitting any pull requests.

Guidelines

  • Please follow the PSR-2 Coding Style Guide, enforced by StyleCI.
  • Ensure that the current tests pass, and if you've added something new, add the tests where relevant.
  • Send a coherent commit history, making sure each individual commit in your pull request is meaningful.
  • You may need to rebase to avoid merge conflicts.
  • If you are changing the behavior, or the public api, you may need to update the docs.
  • Please remember that we follow SemVer.

We have StyleCI setup to automatically fix any code style issues.

Tests

Our current testsuite involves running phpstan on each individual file in tests/Features with our extension file loaded. The test will fail if phpstan fails on the given file. There is currently not a way for us to assert that larastan will fail for a given test suite, so it is difficult to test for expected failures in analysis.