Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FullNodeSpec InstanceOverrides with chain configuration values #437

Open
pharr117 opened this issue Oct 4, 2024 · 1 comment
Open

Comments

@pharr117
Copy link
Contributor

pharr117 commented Oct 4, 2024

The FullNodeSpec contains the InstanceOverrides field:

InstanceOverrides map[string]InstanceOverridesSpec `json:"instanceOverrides"`

This field is a map of pod names to a struct that overrides specific default/global values, and it provides the fields here:

type InstanceOverridesSpec struct {
// Disables whole or part of the instance.
// Used for scenarios like debugging or deleting the PVC and restoring from a dataSource.
// Set to "Pod" to prevent controller from creating a pod for this instance, leaving the PVC.
// Set to "All" to prevent the controller from managing a pod and pvc. Note, the PVC may not be deleted if
// the RetainStrategy is set to "Retain". If you need to remove the PVC, delete manually.
// +kubebuilder:validation:Enum:=Pod;All
// +optional
DisableStrategy *DisableStrategy `json:"disable"`
// Overrides an individual instance's PVC.
// +optional
VolumeClaimTemplate *PersistentVolumeClaimSpec `json:"volumeClaimTemplate"`
// Overrides an individual instance's Image.
// +optional
Image string `json:"image"`
// Sets an individual instance's external address.
// +optional
ExternalAddress *string `json:"externalAddress"`
}

We want to add more fields to this struct to allow overriding other settings on a per-pod basis. This could include:

  1. CometConfig - For overriding values in the config.toml
  2. SDKAppConfig - For overriding values in the app.toml
@pharr117
Copy link
Contributor Author

pharr117 commented Oct 4, 2024

One of the main motivators for this issue is #434

Adding the SDKAppConfig will allow overriding pruning values for specific nodes, since the SDKAppConfig is what sets the pruning values in the app.toml during initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant