Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Combobox from ui-primitives #1032

Open
383bd03d opened this issue May 10, 2023 · 0 comments
Open

[feat]: Combobox from ui-primitives #1032

383bd03d opened this issue May 10, 2023 · 0 comments
Labels
issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: primitives relates to primitives package status: confirmed Confirmed by a Strapi Team member or multiple community members
Milestone

Comments

@383bd03d
Copy link

A clear and concise description of what the feature is

Please add "modal" prop to Root of the Combobox primitive which exist on Radix primitives

Why should this feature be included?

Because radix-ui has these props, they give you more control over the component.

Please provide an example for how this would work

The modality of the popover.
When set to true, interaction with outside elements
will be disabled and only popover content will be visible to screen readers.
@383bd03d 383bd03d added the issue: enhancement Issue suggesting an enhancement to an existing feature label May 10, 2023
@joshuaellis joshuaellis added issue: bug Issue reporting a bug status: confirmed Confirmed by a Strapi Team member or multiple community members source: primitives relates to primitives package and removed issue: enhancement Issue suggesting an enhancement to an existing feature labels May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
@madhurisandbhor madhurisandbhor added the severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: primitives relates to primitives package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Development

No branches or pull requests

3 participants