Fix inadvertent deletion of aggregated ServiceImports on agent restart #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the broker co-exists on a managed cluster, on LH agent restart, the aggregated ServiceImports on the broker are inadvertently deleted during reconciliation. Reconciliation should only process local aggregated ServiceImports and should ignore ServiceImports in the broker namespace. The latter are distinguished by the presence of the "multicluster.kubernetes.io/service-name" annotation. The reconciliation unit test was adjusted to cover this case. Fixes submariner-io/submariner#3188 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1675/tpantelis/fix_si_deletion |
dfarrell07
approved these changes
Nov 14, 2024
vthapar
approved these changes
Nov 15, 2024
|
🤖 Closed branches: [z_pr1675/tpantelis/fix_si_deletion] |
This was referenced Nov 15, 2024
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 15, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 15, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 15, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 15, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 18, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 18, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 18, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 21, 2024
submariner-io/lighthouse#1675 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the broker co-exists on a managed cluster, on LH agent restart, the aggregated
ServiceImportson the broker are inadvertently deleted during reconciliation. Reconciliation should only process local aggregatedServiceImportsand should ignoreServiceImportsin the broker namespace. The latter are distinguished by the presence of the"multicluster.kubernetes.io/service-name" annotation.
The reconciliation unit test was adjusted to cover this case.
Fixes submariner-io/submariner#3188