Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework status Conditions for Globalnet resources #2463

Closed
tpantelis opened this issue Apr 28, 2023 · 0 comments · Fixed by #2487
Closed

Rework status Conditions for Globalnet resources #2463

tpantelis opened this issue Apr 28, 2023 · 0 comments · Fixed by #2487
Assignees
@tpantelis
Labels
priority:high size:small This can be implemented in less than half a sprint technical-debt

Comments

@tpantelis
Copy link
Contributor

The status Conditions are appended to preserve the history however this is contrary to the intended design where each condition type should be unique and only the last status is preserved.
@tpantelis tpantelis self-assigned this Apr 28, 2023
@tpantelis tpantelis added size:small This can be implemented in less than half a sprint size:medium This can be implemented in a single sprint and removed next-version-candidate labels May 3, 2023
@dfarrell07 dfarrell07 added priority:high and removed size:medium This can be implemented in a single sprint labels May 9, 2023
@dfarrell07 dfarrell07 moved this to Todo in Submariner 0.16 May 9, 2023
@tpantelis tpantelis moved this from Todo to In Progress in Submariner 0.16 May 11, 2023
tpantelis pushed a commit to tpantelis/submariner that referenced this issue May 18, 2023
Rework status Conditions for Globalnet resources
7042c5c 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved.

Fixes submariner-io#2463

Signed-off-by: Automated Release <release@submariner.io>
tpantelis pushed a commit to tpantelis/submariner that referenced this issue May 18, 2023
Rework status Conditions for Globalnet resources
7766ee7 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved. Instead of
appending, use meta.SetStatusCondition. Also trim existing conditions
on upgrade to contain only the last one.

Fixes submariner-io#2463

Signed-off-by: Automated Release <release@submariner.io>
@tpantelis tpantelis mentioned this issue May 18, 2023
Merged
tpantelis pushed a commit to tpantelis/submariner that referenced this issue May 18, 2023
Rework status Conditions for Globalnet resources
c899e11 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved. Instead of
appending, use meta.SetStatusCondition. Also trim existing conditions
on upgrade to contain only the last one.

Fixes submariner-io#2463

Signed-off-by: Automated Release <release@submariner.io>
@tpantelis tpantelis moved this from In Progress to In Review in Submariner 0.16 May 18, 2023
tpantelis pushed a commit to tpantelis/submariner that referenced this issue Jun 20, 2023
@tpantelis
Rework status Conditions for Globalnet resources
6f93575 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved. Instead of
appending, use meta.SetStatusCondition. Also trim existing conditions
on upgrade to contain only the last one.

Fixes submariner-io#2463

Signed-off-by: Automated Release <release@submariner.io>
tpantelis pushed a commit to tpantelis/submariner that referenced this issue Jul 31, 2023
@tpantelis
Rework status Conditions for Globalnet resources
55c9c7d 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved. Instead of
appending, use meta.SetStatusCondition. Also trim existing conditions
on upgrade to contain only the last one.

Fixes submariner-io#2463

Signed-off-by: Automated Release <release@submariner.io>
tpantelis pushed a commit that referenced this issue Jul 31, 2023
@tpantelis
Rework status Conditions for Globalnet resources
3b162b5 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved. Instead of
appending, use meta.SetStatusCondition. Also trim existing conditions
on upgrade to contain only the last one.

Fixes #2463

Signed-off-by: Automated Release <release@submariner.io>
@github-project-automation github-project-automation bot moved this from In Review to Done in Submariner 0.16 Jul 31, 2023
novad03 pushed a commit to novad03/k8s-submariner that referenced this issue Nov 25, 2023
@novad03
Rework status Conditions for Globalnet resources
91df995 
The status Conditions are appended to preserve the history however
this is contrary to the intended design where each condition type
should be unique and only the last status is preserved. Instead of
appending, use meta.SetStatusCondition. Also trim existing conditions
on upgrade to contain only the last one.

Fixes submariner-io/submariner#2463

Signed-off-by: Automated Release <release@submariner.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpantelis tpantelis

Labels
priority:high size:small This can be implemented in less than half a sprint technical-debt
Projects
No open projects
Submariner 0.16
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework status Conditions for Globalnet resources tpantelis/submariner
2 participants
@dfarrell07 @tpantelis