Fix golangci-lint 1.54.2 errors #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr2653/tpantelis/fix_lint_errs |
|
There are some linter errors. |
skitt
approved these changes
Aug 22, 2023
The first one needs an additional comment, and the second one will be fixed when Shipyard bumps to 1.54.2 (which means submariner-io/shipyard#1344 needs to be merged before this). |
tpantelis
force-pushed
the
fix_lint_errs
branch
2 times, most recently
from
e31f3a0
to
8465f26
Compare
Ignore this one as the aliasing is OK here:
pkg/cable/wireguard/getconnections.go:66:28:
G601: Implicit memory aliasing in for loop. (gosec)
if k, err := keyFromSpec(&con.Endpoint); err == nil {
pkg/netlink/fake/netlink.go:56:2: directive `//nolint:errorlint...` is
unused for linter "errorlint" (nolintlint)
//nolint:errorlint // The given error should not be wrapped.
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
fix_lint_errs
branch
from
8465f26
to
1ebc14b
Compare
dfarrell07
approved these changes
Aug 22, 2023
sridhargaddam
approved these changes
Aug 23, 2023
|
🤖 Closed branches: [z_pr2653/tpantelis/fix_lint_errs] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore this one as the aliasing is OK here: