Automated backport of #3122: Update multiple GWs failover test to support ROKS as well #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submariner endpoint and gateway names are based on the node's OS.Hostname(). For ROKS the node names are not equal to os.Hostname(), Now that we are going to support multiple gateways for ROKS as well, the name parameter used for searching gateway CR needs to be updated to endpoint.spec.hostname instead of gwpod.spec.nodeName. Signed-off-by: Yossi Boaron <yboaron@redhat.com>
yboaron
requested review from
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr3137/yboaron/automated-backport-of-#3122-origin-release-0.17 |
skitt
approved these changes
Aug 21, 2024
tpantelis
approved these changes
Aug 21, 2024
|
🤖 Closed branches: [z_pr3137/yboaron/automated-backport-of-#3122-origin-release-0.17] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3122 on release-0.17.
#3122: Update multiple GWs failover test to support ROKS as well
For details on the backport process, see the backport requests page.