Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NewClientset instead of NewSimpleClientset #3138

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

skitt
Copy link
Member

@skitt skitt commented Aug 21, 2024

The latter is deprecated in Kubernetes 1.31.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3138/skitt/newclientset
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt marked this pull request as draft August 21, 2024 09:28
The latter is deprecated in Kubernetes 1.31.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt marked this pull request as ready for review August 26, 2024 08:21
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 28, 2024
@tpantelis tpantelis enabled auto-merge (rebase) August 28, 2024 11:44
@tpantelis tpantelis merged commit 9e1f112 into submariner-io:devel Aug 28, 2024
38 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3138/skitt/newclientset]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants