recursivelyCloseSubItems only recurses into open items

sudara · Aug 29, 2023 · 81cc25a · 81cc25a
1 parent 617d282
commit 81cc25a
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/melatonin/components/component_tree_view_item.h b/melatonin/components/component_tree_view_item.h
@@ -194,12 +194,16 @@ namespace melatonin
 
         void recursivelyCloseSubItems()
         {
-            TRACE_COMPONENT("name", getComponentName().toStdString());
+            TRACE_COMPONENT ("name", getComponentName().toStdString());
 
             for (int i = 0; i < getNumSubItems(); ++i)
             {
-                getSubItem (i)->setOpen (false);
-                dynamic_cast<ComponentTreeViewItem*> (getSubItem (i))->recursivelyCloseSubItems();
+                // optimization: only recurse when item is open
+                if (getSubItem (i)->isOpen())
+                {
+                    getSubItem (i)->setOpen (false);
+                    dynamic_cast<ComponentTreeViewItem*> (getSubItem (i))->recursivelyCloseSubItems();
+                }
             }
         }