Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy of migrating to the Jakarta Namespace? #90

Open
rzo1 opened this issue Oct 31, 2023 · 10 comments
Open

Strategy of migrating to the Jakarta Namespace? #90

rzo1 opened this issue Oct 31, 2023 · 10 comments

Comments

@rzo1
Copy link
Contributor

rzo1 commented Oct 31, 2023

Hi all,

We are using the sweble parser in https://github.com/dkpro/dkpro-jwpl and are currently using a relocation/shade approach for the JAXB classes but I would be happy to drop that and just provide a PR moving the actual code towards jakarta.*

Is there any interest in moving that repo towards the jakarta.* namespace and perhaps do a new release afterwards?
Or can I assume, that sweble is mostly dead / unmaintained at the moment?

I see two different solutions:

  • (1) Use a shade / relocation approach and just publish a artifact with a maven classifier jakarta. Benefit: Only one could base needs to be maintained.
  • (2) Hard switch to jakarta.* packages ;-)

Thanks & Gruß
Richard

@rzo1 rzo1 changed the title Jakarta Namespace? Strategy of migrating to the Jakarta Namespace? Oct 31, 2023
@wetneb
Copy link
Member

wetneb commented Oct 31, 2023

I think I can help with reviewing / merging but I am not sure about publishing a new version.

@rzo1
Copy link
Contributor Author

rzo1 commented Oct 31, 2023

It seems, that sweble.org is gone (or do you have control about its DNS settings)?

So if we want to publish to Maven Central (via Sonatype) we would need to change group ids (cf. #85 to sweble.github.io or something) or proof ownership of sweble.org

The mechanical work of doing a release should be straightforward (if gpg is setup, etc.)

@wetneb
Copy link
Member

wetneb commented Nov 1, 2023

I don't control sweble.org but using sweble.github.io sounds good to me.

@rzo1
Copy link
Contributor Author

rzo1 commented Nov 1, 2023

Sounds great, so we would be able to publish under that group id.

I would see two separate PRs:

  1. Change of GroupIDs
  2. Jakarta namespace ready version.

Guess that major change would also imply a version bump.

@rzo1
Copy link
Contributor Author

rzo1 commented Nov 27, 2023

@wetneb Do you know who is still active in Erlangen or what does it need to move forward? I am asking because we want to avoid forking :)

@wetneb
Copy link
Member

wetneb commented Nov 29, 2023

I don't think there is much activity, but we can always reach out to the original authors if we are lacking permissions. I don't have much time to work on this at the moment but I'll happily merge PRs and deploy releases as needed.

@magicDGS
Copy link

Hey there! Do you know if this is still on plan, @wetneb and/or @rzo1? I would like to use Sweble on a java-21 application and I cannot use the engine dependency but only the parser one, meaning that I have to do some parsing manually that is already implemented on the engine. Thank you very much in advance!

@rzo1
Copy link
Contributor Author

rzo1 commented Apr 10, 2024

Didn't get much feedback on the related PR. For JWPL, I did a relocate which might be an Option for you too: https://github.com/dkpro/dkpro-jwpl/blob/master/dkpro-jwpl-deps%2Fdkpro-jwpl-swc-engine-shade%2Fpom.xml

@magicDGS
Copy link

Isn't the relocate only working on the package phase? I was trying to mimic that strategy, but my tests on the IDE were failing as the package was not present.

I saw that you mentioned to fork (although I agree that I will prefer not to), but with the new java release pace it might be difficult to keep using the most complete wikitext parser out there if it is unmaintained. And writing an own parser is a route that I don't want to take for this use-case.

If there is some interest in maintaining a fork only for the shake of modernizing the toolstak and dependencies, even if no new features are added, maybe it is an option that should be considered. Otherwise it will be sad to lose the work done with sweble in the past.

@rzo1
Copy link
Contributor Author

rzo1 commented Apr 10, 2024

It depends - we have used it in Apache TomEE a lot for example . You can attach the relocation artifact to your IDE. There is a bit of Maven hackery available for it but not the preferred option, I agree 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants