Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: oci: buildkit TMPDIR fallback #3407

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Nov 22, 2024

Description of the Pull Request (PR):

Work in progress....

Use a TMPDIR location if the ~/.singularity/singularity-buildkitd location is on a filesystem that won't work for buildkit (as determined by overlay.CheckUpper which is used elsewhere also).

This should fix #3382 but the current PR is not suitable to merge. Exit handling is pretty nasty due to the flow in which singularity-builtkitd is started, and waited for, by singularity as a buildkit client. We don't really have a nice termination route prior to the GRPC server being started... but the TMPDIR and config needs to be setup before that.

Needs re-work of how we launch singularity-buildkitd and catch errors client-side that are earlier / not visible across the client->server socket.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

singularity build --oci fails when $HOME/.singularity/singularity-buildkitd is on NFS
1 participant