Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status is not updated to "Needs review" after pushes #150

Open
wouterj opened this issue Jan 3, 2021 · 3 comments
Open

Status is not updated to "Needs review" after pushes #150

wouterj opened this issue Jan 3, 2021 · 3 comments

Comments

@wouterj
Copy link
Contributor

wouterj commented Jan 3, 2021

The README says:

Finally, the status will be "Needs review" after the author pushes changes to the PR.

However, I haven't yet experienced this. Most recent example where I manually had to switch the status: symfony/symfony#39696

(I'm not sure if this is a bug, or an invalid README, it can make sense to not automatically switch the status after a push)
@stof
Copy link
Member

stof commented Mar 5, 2021

It is done only if the existing status is "needs work".

@wouterj
Copy link
Contributor Author

wouterj commented Mar 5, 2021

image

Yes, that's the case here (but maybe I was too quick).

@ahmedghanem00
Copy link

I've experienced this here also, when I pushed a change to the PR, the status did not change automatically to Needs review. And I think this happened with me couple of times before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stof @wouterj @ahmedghanem00