Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ask to fix the target branch if it's the next development branch (not yet created) #230

Open
chalasr opened this issue May 20, 2024 · 1 comment

Comments

@chalasr
Copy link
Contributor

chalasr commented May 20, 2024

During the stabilization phase of a minor version including feature-freeze and beta/RC releases, submitted features are expected to target the next minor version i.e. if we are stabilizing 7.1, we want feature PRs to target 7.2.
In such periods, when a PR really targets the wanna-be-stable branch but indicates to target the next one, carsonbot should not consider it a mismatch - and so should not ask to change the target branch, since the contributor just cannot make its PR target the right branch at the moment (they have to come back and do it later, when the branch is created).

Example: symfony/symfony#56831

@stof
Copy link
Member

stof commented Aug 29, 2024

The reason why we don't create the next development branch at the beginning of the feature freeze but only when publishing the RC release is to focus contributions on stabilizing the upcoming release instead of working on the next one.

So I would not change things here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants