Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird html escape with invalid link reference #171

Open
danielburger1337 opened this issue Feb 6, 2024 · 2 comments
Open

Weird html escape with invalid link reference #171

danielburger1337 opened this issue Feb 6, 2024 · 2 comments

Comments

@danielburger1337
Copy link

First off, I'm not quite sure what the underlying issue is (and even it is one) and whether this is an upstream issue with the RST-parser or not:

I was looking at the scheb/2fa-bundle documentation to see whether the updated docs are live yet and saw that an added link to packagist.org wasn't correctly displayed. Looking at the html-markup revealed the following (see image):

Screenshot_20240206_235808

The RST-source file was missing a space between the link and the text. PR to fix that has been made.

# original
`related packages on Packagist.org<https://packagist.org/packages/scheb/2fa-bundle/dependents>`_.
# fixed 
`related packages on Packagist.org <https://packagist.org/packages/scheb/2fa-bundle/dependents>`_.

Is it intended behavior to be able to embed html elements like that? To me it looks like there is some sort of escaping going on since the slashes have been removed from the html-source and the escaping might have failed?

@homersimpsons
Copy link
Contributor

homersimpsons commented Aug 1, 2024

I think this issue can be closed as scheb/2fa#220 is merged.

Edit: I wrngly interpreted the pull request.

@stof
Copy link
Member

stof commented Sep 11, 2024

It looks like doctrine/rst-parser does not properly escapes the content of the link text (and the whole related packages on Packagist.org<https://packagist.org/packages/scheb/2fa-bundle/dependents> gets parsed as the link text, which is expected according to the spec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants