Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 7 - When gtid_set is blank binlog_reader fails to start #12

Closed
wants to merge 1 commit into from
Closed

Issue 7 - When gtid_set is blank binlog_reader fails to start #12

wants to merge 1 commit into from

Conversation

altmannmarcelo
Copy link

Function gtid_executed_to_string was trying to do a pop_back on empty
gtid_set, which was causing basic_string::erase.

Now the code only execute the pop if gtid_set is not empty and also
report proper error indicating the empty gtid_executed.

Closes #7

@altmannmarcelo
Copy link
Author

Example error log:

Sucessfully started
Angel process started ProxySQL MySQL Binlog process 1241
2020-02-07 19:03:37 [INFO] Initializing client...
2020-02-07 19:03:37 [INFO] Trying to read gtid_executed, empty set detected!
2020-02-07 19:03:37 [INFO] Exiting...
Shutdown angel process

@altmannmarcelo
Issue 7 - When gtid_set is blank binlog_reader fails to start
234a356 
Function gtid_executed_to_string was trying to do a pop_back on empty
gtid_set, which was causing basic_string::erase.

Now the code only execute the pop if gtid_set is not empty and also
report proper error indicating the empty gtid_executed.
@altmannmarcelo altmannmarcelo closed this by deleting the head repository Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When gtid_set is blank binlog_reader fails to start
1 participant
@altmannmarcelo