Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests refactor #113

Open
2 tasks
miporto opened this issue May 10, 2017 · 2 comments
Open
2 tasks

Tests refactor #113

miporto opened this issue May 10, 2017 · 2 comments

Comments

@miporto
Copy link
Member

miporto commented May 10, 2017

  • Modularize tests
  • Add real artists and albums for tests
@aibarbetta
Copy link
Member

For each entity * (for example; user, track, album, artist, ...) we should split the tests in modules:

  • *.admin.spec.js creation, update, deletion, fetch
  • *.me.spec.js endpoints that require the user id in the auth token
  • *.extra.spec.js everything else¿?

Each one with its own constants:

  • *.admin.constants.json
  • *.me.constants.json
  • *.extra.constants.json

@miporto
Copy link
Member Author

miporto commented May 12, 2017

And move them to it's own folders (test/routes/artists/..., test/routes/albums/..., etc)

@miporto miporto changed the title Fix tracks tests Fix tests May 23, 2017
@aibarbetta aibarbetta changed the title Fix tests Tests refactor May 25, 2017
aibarbetta added a commit that referenced this issue May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants