Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claim about manipulating shader uniform though JS API is ambiguous #273

Open
westnordost opened this issue Apr 8, 2022 · 0 comments
Open

Comments

@westnordost
Copy link

The docs state

The uniforms block allows shortcuts for declaring globally-accessible uniform variables, for use in the global, position, normal, color and filter blocks. Uniforms declared here may also be accessed and manipulated through the JavaScript API.

Source: https://github.com/tangrams/tangram-docs/blob/44939085d5145417b2a5cd18e57287864bde33b7/docs/Syntax-Reference/shaders.md#uniforms

This can be misunderstood to mean that uniforms can be defined dynamically depending on certain feature properties. The documentation should make clear that a shader is in that sense static (or whatever is the best word).

Follow-up of tangrams/tangram-es#2319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant