From 94987bbc73a4dae9aacc0c6b93c7ca873c7617c7 Mon Sep 17 00:00:00 2001
From: yostyle <y.pintas@gmail.com>
Date: Tue, 14 May 2024 16:54:31 +0200
Subject: [PATCH] Fix PR comments

---
 tools/release/sign_all_apks_yubi.sh | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/tools/release/sign_all_apks_yubi.sh b/tools/release/sign_all_apks_yubi.sh
index 6bdc5229ea..eb3a0db09d 100755
--- a/tools/release/sign_all_apks_yubi.sh
+++ b/tools/release/sign_all_apks_yubi.sh
@@ -50,22 +50,16 @@ unzip ${PARAM_DIRECTORY}/GplayTchapWithdmvoipWithpinning-release-unsigned.zip -d
 mv ${PARAM_DIRECTORY}/gplayTchapWithdmvoipWithpinning/release/* ${PARAM_DIRECTORY}
 rm -rf ${PARAM_DIRECTORY}/gplayTchapWithdmvoipWithpinning
 
+read -s -p "Enter your PIN: " pin
+
 printf "\n================================================================================\n"
 printf "Signing the APKs...\n"
 
-read -s -p "Enter your PIN: " pin
-
-# Sign all the apks in the directory PARAM_DIRECTORY
+# Sign, Rename and Hash all the apks in the directory PARAM_DIRECTORY
 for file in ${PARAM_DIRECTORY}/*.apk
 do
   sh ./tools/release/sign_apk_yubi.sh "${PARAM_PKCS11_CONFIG_PATH}" "${file}" "${pin}"
-done
-
-unset pin
-
-# Rename and Hash all the apks in the directory PARAM_DIRECTORY
-for file in ${PARAM_DIRECTORY}/*.apk
-do
+  
   # Rename Apk: remove unsigned by signed
   apkName="$(echo ${file} | sed -e 's/\-unsigned/-signed/')" ;
   mv "${file}" "${apkName}" ;
@@ -80,4 +74,6 @@ do
   echo "SHA256(${newName})=${resultSplit[0]}" >> ${PARAM_DIRECTORY}/${CHECKSUM_FILE}
 done
 
+unset pin
+
 echo "done !! :)"