Use stable features where possible #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`io::copy()` as well as the `BufReader`/`BufWriter` don't need nightly Rust anymore as they the features needed are available on more recent stable Rust versions. This commit bumps the MSRV to 1.55. Closes technocreatives#15.
I don't think this is correct. The current code reveals uninitialized memory which is generally UB. The new method (still unstable) is to use https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_buf. For now, I'd suggest just initializing a buffer unless nightly is available. |
The doc tests currently don't compile, this is not a regression, it has been the case even before the previous commit.
|
I wanted to many thing at the same time with this PR. This should be split into separate ones:
Hence I'm closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io::copy()as well as theBufReader/BufWriterdon't need nightlyRust anymore as they the features needed are available on more recent
stable Rust versions. This commit bumps the MSRV to 1.55.
Closes #15.