Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy in telepresence agent rejects http 1.0 #3169

Open
nicks opened this issue May 9, 2023 · 2 comments
Open

Envoy in telepresence agent rejects http 1.0 #3169

nicks opened this issue May 9, 2023 · 2 comments
Labels
enterprise feature New feature or enhancement request

Comments

@nicks
Copy link
Contributor

nicks commented May 9, 2023

Describe the bug
When I intercept traffic under certain conditions, Telepresence kills all traffic, even traffic that's not being intercepted.

To Reproduce
See this repro:
https://github.com/nicks/telepresence-sandbox
which has a detailed setup

Once I get into this state, all HTTP requests return error code 426

Expected behavior
I expect Telepresence to intercept the traffic that matches my header, and leave all other traffic alone.

Once telepresence gets into this state, the only way to fix it is to uninstall the agent.

telepresence uninstall -d my-proxy

Notably, telepresence leave does not fix the problem.t

Versions (please complete the following information):

telepresence version
An update of telepresence from version 2.12.2 to 2.13.1 is available. Please visit https://www.getambassador.io/docs/telepresence/latest/install/upgrade/ for more info.
Client         : v2.12.2
Root Daemon    : v2.12.2
User Daemon    : v2.12.2
Traffic Manager: v2.12.2

see attached repo for kubernetes

kubectl version --short
Client Version: v1.27.1
Kustomize Version: v5.0.1
Server Version: v1.25.7+k3s1

@nicks
Copy link
Contributor Author

nicks commented May 11, 2023

Ok, narrowed down the bug: telepresence uses envoy to manage agent traffic. envoy, by default, rejects all http 1.0 requests. envoyproxy/envoy#170

nginx, by default, sends http 1.0 requests. http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_http_version

it would be good if telepresence updated the agent's envoy config to accept http 1.0.

@cindymullins-dw cindymullins-dw added the feature New feature or enhancement request label May 15, 2023
@thallgren thallgren changed the title telepresence agent kills all traffic with http error 426 Envoy in telepresence agent rejects http 1.0 Feb 4, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and will be closed label Aug 16, 2024
@thallgren thallgren added enterprise and removed stale Issue is stale and will be closed labels Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants