Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No firewall rule created to allow health check if health check port does not match backend port. #121

Open
DeanBrunt opened this issue Aug 28, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work

Comments

@DeanBrunt
Copy link
Contributor

Currently, if I specify the health check port for a backend to be different to the port for the backend, no firewall rule to allow health checking on the health check port is created.

A quick squint at the terraform suggests this is because we, presumably incorrectly, use the value of port for each backend for the firewall rule, not that of the health check port.

@morgante
Copy link
Contributor

Yeah this looks like a bug. We would need to update this resource to use HC ports.

@morgante morgante added bug Something isn't working good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work labels Aug 28, 2020
@DeanBrunt
Copy link
Contributor Author

I was going to just raise a PR for this but couldn't remember what the behaviour would be if we looped over health checked backends in the case that there were 0 (therefore giving the firewall rule no allow blocks), so will have to give this a test

@tpoindessous
Copy link
Contributor

Hi @DeanBrunt , we are interessed by this feature because we use goss-server as healthcheck server.

Any idea when you could tackle this issue ? Do you need any help ?

Thanks !

@DeanBrunt
Copy link
Contributor Author

Hey @tpoindessous ,

I suspect I'll get round to this within the next couple of weekends or so.
The change should be fairly simple as it should be a case of updating the resource that @morgante referenced to use the HC ports.

If you've got bandwidth to tackle this that would be great, else I'll look to do it at a juncture when I've got some spare time.

custodianbot pushed a commit to bycustodian/terraform-google-lb-http that referenced this issue Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants