Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated Composite sub-class for modeling particle fuel #1055

Open
drewj-usnctech opened this issue Jan 3, 2023 · 2 comments
Open

Dedicated Composite sub-class for modeling particle fuel #1055

drewj-usnctech opened this issue Jan 3, 2023 · 2 comments
Labels
feature request Smaller user request

Comments

@drewj-usnctech
Copy link
Contributor

drewj-usnctech commented Jan 3, 2023

I've been thinking about how our downstream clients will detect the presence of particle fuel. Looking at discussions in

🚨 a lot of the earlier description / design / acceptance criteria is duplicated in and moved to #1134 🚨

Encourage a specific Composite subclass where the children are all spheres to model one particle fuel object. Some specific design concepts / requirements

  1. Children are only allowed to be Sphere Components
  2. Multiplicity of each child is one as there is one layer of each material with a certain radii in a kernel. For your "standard" TRISO (Make standard way to represent TRISO fuel #228), this would be
    • fuel kernel
    • porous graphite layer
    • inner pyrolytic graphite
    • inert layer of SiC
    • outer pyrolytic graphite (same Material as inner pyrolytic graphite, but with different id and od parameters
  3. Multiplicity of the ParticleFuel itself can be greater than one to signify the number of a given particle in the parent Compact - Provide a Compact class to hold particle fuel and matrix #1134
  4. Multiplicity must be able to be serialized / deserialized from database
    • so stored as a parameter?
  5. Layers are not allowed to be overlapping
  6. Support for linked dimensions (as fuel kernel expands, inner diameter of next layer increases)
    • Not trying to add in a fully feature TRISO expansion routine, but linked dimensions will help support that
  7. Iteration goes from innermost layer to outermost layer
  8. Item access via __getitem__ picks up the given layer, so pf[0] would be the innermost, pf[-1] would be the outermost, etc.
@john-science john-science added the feature request Smaller user request label Jan 3, 2023
@john-science john-science changed the title Dedicated composite sub-class for modeling particle fuel Dedicated Composite sub-class for modeling particle fuel Jan 3, 2023
@john-science
Copy link
Member

I'd be happy to have a ParticleFuelCompact class in ARMI. At a guess, we'd want to wait until #1008 is done to try implementing this.

We would want to support it in the blueprint readers, too. That's always a fun part.

@drewj-usnctech
Copy link
Contributor Author

Realized that the design here is largely duplicated from #1134 so I updated the description and acceptance criteria to be specific to the thing that models one particle fuel particle. Let me know if you'd like to see any changes @john-science @slee-USNC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

No branches or pull requests

2 participants