Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Protocol support for container port bind and expose #690

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(core): Protocol support for container port bind and expose #690

wants to merge 10 commits into from

Conversation

Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented Aug 21, 2024 •
edited
Loading

Fix: #674

Changes:

  1. Proper type hinting for ports bindings, support strings like 8080/tcp or 8125/udp
  2. Backward compatible with int
  3. More test coverage
  4. Improve documentations regarding the usage of with_bind_ports and with_exposed_ports

Any comments will be appreciated

@Tranquility2 Tranquility2 mentioned this pull request Aug 21, 2024
Open
@Tranquility2 Tranquility2 marked this pull request as draft August 21, 2024 21:41
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@82a2e7b). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage        ?   85.73%           
=======================================
  Files           ?       12           
  Lines           ?      659           
  Branches        ?      103           
=======================================
  Hits            ?      565           
  Misses          ?       72           
  Partials        ?       22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tranquility2 Tranquility2 marked this pull request as ready for review August 22, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderankin alexanderankin alexanderankin approved these changes

Assignees
No one assigned
Labels
intend to merge this or some version of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Proper type hinting for UDP ports bindings
2 participants
@Tranquility2 @alexanderankin