-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config values prepended with HYPERGLASS_APP_PATH
#253
Comments
I've opened this issue so as not to comment back and forth on a closed PR. @allanfrizzo - can you confirm that you've both pulled the latest copy of the repo, rebuilt the container ( |
I've rebuilt the container with v2.0.1, pushed it to my fork's packages with the rootless fix I did in #250, and it works as expected. |
I removed the docker image and rebuilt it, now it's up as expected, thanks |
After submitting PR #256, the current fixes worked for me since I don't have any "." in my configuration. However, the issue still persists in cases like |
I get the error when inserting a link, it keeps adding the path in front. config.yalm org_name: Eaí
error log: I noticed that when I used a menu item, it added the path. |
Yes as I've mentioned above if you have a "." the issue still persists |
With the following configuration, I cannot reproduce this with 2.0.1: web:
menus:
- title: Contact
content: Do a thing
order: 1 Are you sure you're on 2.0.1? |
Are you testing with docker ? (because the issue is only triggered here) hyperglass/hyperglass/models/main.py Line 66 in 0c643c6
|
before this adjustment, the urls were also giving errors.
|
@M0NsTeRRR yes, using Docker. @allanfrizzo Have you tried rebuilding the container? |
I did the whole process again,
|
Yes #249 is not a working solution as it breaks other things. I got the same issue as @allanfrizzo (just tested with a new build and with this config). I think your Docker didn't rebuild because you had it in cache. Try running
|
If that works, I'll add |
Still the same error.
|
I mean the issue is on your side @thatmattlove, try to test with the command i've provided you should have the same issue as we have with @allanfrizzo. hyperglass/hyperglass/models/main.py Line 65 in 0c643c6
|
I understand what you mean now. I have With that knowledge, I was able to reproduce the issue and have solved it with: if isinstance(value, str) and str(Settings.original_app_path.absolute()) in value:
if Settings.container:
path = Path(value)
return str(
Settings.default_app_path.joinpath(
*(
p
for p in path.parts
if p not in Settings.original_app_path.absolute().parts
)
)
) I'll get that into 2.0.2 and pushed up shortly. |
I'm using the default configuration HYPERGLASS_APP_PATH=/etc/hyperglass |
Yes exactly but we are not setting the variable as we don't need it. value.startswith(str(Settings.original_app_path.absolute())) is better than str(Settings.original_app_path.absolute()) in value |
with the adjustments worked as expected. |
See #249
The text was updated successfully, but these errors were encountered: