Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker frontend build system #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

M0NsTeRRR
Copy link
Contributor

@M0NsTeRRR M0NsTeRRR commented Jul 19, 2024

Description

  • Fix the build system by saving the build ID in a separate env file in the Docker-mounted folder. Placing the env file in the static folder allows users to mount only the static directory and, in a separate step, mount the required config files (config.yaml, device.yaml) for Kubernetes and GitOps setups.
  • I've moved the env file creation to the end; in case there is an issue in the build generation, the build file is not generated, and the next restart will trigger a rebuild.
  • There is an additional fix regarding the build id that also affects the current version and older ones wheremodel_dump keys are not sorted, which could trigger a rebuild if the keys were swapped compared to the last build.

Related Issues

Fixes #278

Motivation and Context

I want to speed up pod restarts in my Kubernetes environment, so I need to avoid rebuilding the frontend every time.

Tests

Tested in docker & kubernetes environment

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker rebuild frontend every time
1 participant