Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turret can rotate past soft limits #135

Open
mlists opened this issue Mar 1, 2020 · 4 comments
Open

Turret can rotate past soft limits #135

mlists opened this issue Mar 1, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@mlists
Copy link
Contributor

mlists commented Mar 1, 2020

This behaviour has been observed when the turret starts anti-clockwise of the left index. This position violates the rules around starting configuration and is extremely unlikely to occur during games (We are 180 degrees from our intended start). The same situation could conceivably happen if scan direction is reversed from a more conventional starting position.

Because this is unlikely to occur, a fix to this bug should be considered low priority, as long as scans start anti-clockwise first

@raulvera59
Copy link
Contributor

Hypothesis: this happens when the turret's first scan move takes it beyond what would have been it's end point in the correct space. Then the correction puts the encoder behind where the turret is now, so it keeps on going.

@raulvera59
Copy link
Contributor

Note: scans do start anti-clockwise first

@auscompgeek
Copy link
Member

We should set the soft limits on the Talon to avoid this ever actually becoming a problem. Then it becomes a matter of making scans behave appropriately before hitting an index.

@mlists
Copy link
Contributor Author

mlists commented Mar 7, 2021

Reviving this issue since certain starting configurations can cause the turret to seemingly zero incorrectly

@auscompgeek auscompgeek added the bug Something isn't working label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants