Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untangle fetch_sources and setup_sources roles #219

Open
evgeni opened this issue Oct 30, 2019 · 1 comment
Open

untangle fetch_sources and setup_sources roles #219

evgeni opened this issue Oct 30, 2019 · 1 comment

Comments

@evgeni
Copy link
Member

evgeni commented Oct 30, 2019

"We have two roles right? fetch_sources and setup_sources ? I think that is breeding a lot of my confusion. I recall what the fetch_sources role was born out of a bit more now and I think maybe we need to re-consider it's name? or maybe it's purpose. That is, for something that makes you think it fetches sources, it does updating at the same time. Not your design, but I wondered if you had thoughts from doing this split out of how it could be renamed or broken out such that it makes the responsibility of the role cleaner."

Originally posted by @ehelms in #216 (comment)

Probably they need splitting and renaming to better expose what they do.

@ekohl
Copy link
Member

ekohl commented Oct 30, 2019

As an aside: I think the update role should also only include roles. Currently it includes tasks to do git annex + commit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants