Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename BMC #10

Closed
johannesgiersdorf opened this issue Feb 11, 2021 · 2 comments · Fixed by #11
Closed

Rename BMC #10

johannesgiersdorf opened this issue Feb 11, 2021 · 2 comments · Fixed by #11

Comments

@johannesgiersdorf
Copy link
Collaborator

johannesgiersdorf commented Feb 11, 2021

I would suggest to rename BMC.
Bayesian Monte Carlo, the simplest approach for Bayesian Quadrature. Assumes that the prior is Gaussian and that the integrand is as well
https://github.com/theogf/BayesianQuadrature.jl/blob/d621e84566cbcafa7cbe13a6036873479b19471d/src/integrators/bmc.jl#LL1-L7

It is true that it is motivated by the example from the paper and it should be referenced (I suggest in the readme). It is misleading to use the name BMC in the quadrature part (BMC refers more on how to sample the states and than use BQ).

I would refer instead to the distribution (or even kernel-distribution pair), where the distribution is the one we are importance re-weighting "against" (e.g. Gaussian in the simple case (SE kernel - Gaussian)).

See also 4.2 Tractable and Intractable Kernel Means
Briol, F. X., Oates, C. J., Girolami, M., Osborne, M. A., & Sejdinovic, D. (2019). Probabilistic integration: A role in statistical computation?. Statistical Science, 34(1), 1-22.

Remark: The idea is having kernel-distribution pairs with a closed form kernel mean.
the case (SE kernel - Gaussian) is called Bayes–Hermite quadrature
O’Hagan, A. (1991). Bayes–Hermite quadrature.J. Statist. Plann. Inference, 29:245–260.

@theogf
Copy link
Owner

theogf commented Feb 11, 2021

That's a good point! Naming things is always complicated...

But here is my current thought about how to split things (updated from #1)

  • The model (a subtype of AbstractMCMC.Model) which contains the prior and the integrand, the reweighting can simply happen in here (by dispatching the prior and integrand function)
  • The sampling, i.e how are samples selected)
  • The integration are we using bayesian quadrature or is there some more fancyness happening (Variational BQ etc)
  • The kernel means, we should have a generic implementation relying on either MC or Quadrature, maybe table being reused for weighting? As well as specific implementations for tractable kernels.

Would you have a suggestion for a better name?

@johannesgiersdorf
Copy link
Collaborator Author

johannesgiersdorf commented Feb 11, 2021

BMC -> BH (Bayes-Hermite) < TKM (Tractable Kernel Means) < AbstractIntegrator
Alt. BMC -> BQ (Bayesian Quadrature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants