Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure with unrecognized token #2

Open
gabrielgrant opened this issue Dec 2, 2023 · 1 comment
Open

Failure with unrecognized token #2

gabrielgrant opened this issue Dec 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gabrielgrant
Copy link

This is great, thanks for putting this together :)

It seems the demo fails with pretty inelegantly right now on inputs that it can't parse (eg 5 == invalidToken)

Any thoughts on how to improve the error handling?
@thesayyn
Copy link
Owner

Currently this repo is incomplete, parse errors are not handled at all, they are simply panic!. It would probably return Result for unknown tokens.

@thesayyn thesayyn added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielgrant @thesayyn