Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: refactor extension matchers #113

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Aug 3, 2024

Refactor extension matchers so that they can easily be reused to reduce the effort required to support a new extension repository (#47).

@github-actions github-actions bot added breaking Change that breaks backwards compatibility internal An internal refactor or improvement labels Aug 3, 2024
Copy link

github-actions bot commented Aug 3, 2024

🐰Bencher

ReportSat, August 3, 2024 at 20:44:41 UTC
Projecttheseus-rs/postgresql-embedded
Branchrefactor-extension-matchers
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
extract➖ (view plot)153,470.00
lifecycle➖ (view plot)1,855,200,000.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.19%. Comparing base (3cdd9c5) to head (62edcd5).

Files Patch % Lines
postgresql_extensions/src/matcher.rs 95.89% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   99.23%   99.19%   -0.05%     
==========================================
  Files          95       93       -2     
  Lines        9846     9805      -41     
==========================================
- Hits         9771     9726      -45     
- Misses         75       79       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 090e0bd into main Aug 3, 2024
12 of 13 checks passed
@brianheineman brianheineman deleted the refactor-extension-matchers branch August 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change that breaks backwards compatibility internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant