Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on benchmark hyperparameters #1220

Open
5 of 9 tasks
RolandStolz opened this issue Oct 9, 2024 · 1 comment
Open
5 of 9 tasks

Question on benchmark hyperparameters #1220

RolandStolz opened this issue Oct 9, 2024 · 1 comment

Comments

@RolandStolz
Copy link

RolandStolz commented Oct 9, 2024

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
    • design request (i.e. "X should be changed to Y.")
  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:
    import tianshou, gymnasium as gym, torch, numpy, sys
    print(tianshou.__version__, gym.__version__, torch.__version__, numpy.__version__, sys.version, sys.platform)

First of all, thank you for the very detailed benchmark descriptions. That is truly amazing!
However, I am having trouble finding the specific hyperparameters used for the benchmarks.

Are the used hyperparameters just the ones provided in the default arguments (e.g. lines 25-75 in examples/mujoco/mujoco_ppo.py)?
If so, that would mean that you used the same hyperparameters for all mujoco environments, which I hardly believe is the case.
I feel like I'm missing something here.

Any help is greatly appreciated!

@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented Oct 9, 2024

I believe it's the default hyperparameter. You can checkout the commit mentioned in the benchmark page and see what's actually ran at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants