Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Remove useless metadata table _timescaledb_catalog.continuous_aggs_bucket_function #7349

Open
fabriziomello opened this issue Oct 15, 2024 · 4 comments · May be fixed by #7532
Labels
continuous_aggregate tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.

Comments

@fabriziomello
Copy link
Contributor

What type of enhancement is this?

Tech debt reduction

What subsystems and features will be improved?

Continuous aggregate

What does the enhancement do?

Remove useless metadata table _timescaledb_catalog.continuous_aggs_bucket_function. This table is not necessary anymore because we already refactored the current code to get the bucket function Oid based on the query tree stored on Postgres metadata (#7042).

Implementation challenges

No response

@fabriziomello fabriziomello added continuous_aggregate tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. labels Oct 15, 2024
@fabriziomello fabriziomello changed the title [Enhancement]: <Title> [Enhancement]: Remove useless metadata table _timescaledb_catalog.continuous_aggs_bucket_function Oct 15, 2024
@K-Kumar-01
Copy link

@fabriziomello
Can I work on the issue if no one else has started working on it?

@philkra
Copy link

philkra commented Dec 14, 2024

@K-Kumar-01 yes, feel free to submit a PR. Thank you

@fabriziomello
Copy link
Contributor Author

fabriziomello commented Dec 14, 2024

@K-Kumar-01 yes, feel free to submit a PR. Thank you

I've sent an old PR I started months ago: #7532

It is in WIP stage and I noticed a small bug and sent another to fix before continue on it: #7533.

But if you want to continue this work I'll be more than happy to guide you.

@K-Kumar-01
Copy link

Hi @philkra
Thanks for replying.
@fabriziomello
I will look at your PRs today starting 7533 followed by 7532. I will post my insights here as soon as possible.
Thank you for your help.

@fabriziomello fabriziomello linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous_aggregate tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants