Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set timeout on requests? #43

Open
thesoloist opened this issue Feb 1, 2020 · 2 comments
Open

Option to set timeout on requests? #43

thesoloist opened this issue Feb 1, 2020 · 2 comments
Labels
backlog Issues that haven't been categorized or are not yet ready for work feature Feature requests or improvements

Comments

@thesoloist
Copy link

sometimes network connection gets held up for long period of time(minutes or more), an option to add request timeout and throw exception when timed out would be nice.

@dahifi
Copy link
Collaborator

dahifi commented Feb 16, 2020

+1. There needs to be some exception handling added for 40x errors as well. It's on my list of stuff to do.

@timkpaine timkpaine added feature Feature requests or improvements ready Issues ready to be worked on labels Feb 16, 2020
@timkpaine timkpaine added backlog Issues that haven't been categorized or are not yet ready for work and removed ready Issues ready to be worked on labels Apr 8, 2020
@dahifi
Copy link
Collaborator

dahifi commented May 12, 2020

I think the most straightforward way to do this right now is by modifying the TDASession.request function, but I'm not sure the best way to incorporate this into the package. 12-factor dictates it should be outside of it, maybe an env setting? Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues that haven't been categorized or are not yet ready for work feature Feature requests or improvements
Projects
None yet
Development

No branches or pull requests

3 participants