Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong address for total running time in SG5K-D.yaml #26

Open
icypete opened this issue Jan 12, 2021 · 5 comments
Open

Wrong address for total running time in SG5K-D.yaml #26

icypete opened this issue Jan 12, 2021 · 5 comments

Comments

@icypete
Copy link
Contributor

icypete commented Jan 12, 2021

In the example file SG5K-D.yaml the address for total running time is incorrect. The file has

- pub_topic: "total_yield" #Total yield kWh address: 5003 table: 'input' - pub_topic: "total_running_time" #Total running time (h) address: 5003 table: 'input'

I think 5003 should be replaced by 5005 for total_running_time

@icypete
Copy link
Contributor Author

icypete commented Jan 13, 2021

also missing "scale:" for most entries. i can update the file if it is helpful.

@tjhowse
Copy link
Owner

tjhowse commented Jan 13, 2021

Unfortunately I don't have an SG5k-D to test with, @jmkelly is there a chance you could see if input table address 5005 contains a constantly-increasing value on your system that could be a total_running_time?

Further, looking at these docs for the SH5k-20:

Holding registers:
image

Input registers:
image

These numbers include a +1 offset from how addresses are represented in modbus4mqtt, so assuming this memory map for the SH5k-20 is accurate for an SG5k-D, input table 5003-5004 is a uint32 for total energy output and holding table 5003 is system clock minutes? I'm not seeing anything in this doc about a total_running_time value though.

@icypete
Copy link
Contributor Author

icypete commented Jan 14, 2021

ah. the guide i was using has;

image

I have an SG8K-D inverter and the 5005 address does contain a value that increases by 1 each hour. i have been assuming the SG8K-D and SG5K-D use the same mappings though

@icypete
Copy link
Contributor Author

icypete commented Jan 14, 2021

SG8K-D.zip

Attached is a working sample config file for SG8K-D. It was created from the SG5K-D.yaml file but I correct an address that was wrong and added the correct "scale:" values that were missing.

Note: it includes an example of a 32 bit signed value that needs the code changes I attached to #6

I have tested the config with my SG8K-D unit and all fields work.

@jmkelly
Copy link
Contributor

jmkelly commented Jan 15, 2021

oops, my bad, I had just a typo. I've updated to total_running_time to 5005 on my SG5K-D, but now the sun is gone.

Once the changes are merged from #6 I'll give the new registers a crack (as I'm particularly interested in the charge back number) and happy to update the SG5K-D yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants