Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modbus device IP override to the launch arguments #30

Open
tjhowse opened this issue Jan 17, 2021 · 1 comment
Open

Add a modbus device IP override to the launch arguments #30

tjhowse opened this issue Jan 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@tjhowse
Copy link
Owner

tjhowse commented Jan 17, 2021

The IP addresses in the example YAMLs are not useful to the majority of people. It would make it easier for people to use the bundled YAMLs directly if the IP address of the modbus device could be overridden in a launch argument.

@tjhowse tjhowse added the enhancement New feature or request label Jan 17, 2021
@woifes
Copy link

woifes commented Jun 5, 2024

I was about to write a similar suggestion. I am just planing the deployment fo multiple instances of this service. The devices have identical modbus registers but ofc different IP addresses. If the modbus IP is a launch argument, I can map the same register definiton into every container via docker compose but override the IP in the compose file for each instance.

An alternative would be to allow the register definiton in a separate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants