Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default register values should be set when the YAML is loaded, not anywhere they're accessed #31

Open
tjhowse opened this issue Jan 17, 2021 · 0 comments

Comments

@tjhowse
Copy link
Owner

tjhowse commented Jan 17, 2021

Any optional value of a register should be set to its default value in the for register in self.registers: loop in mqtt_interface.__init__(), rather than using register.get(field, 'default') throughout the code. The defaults for each register value should be declared in a top-level CONST map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant