First off, thank you for considering contributing to nem2-sdk-java. It’s people like you that make nem2-sdk-java such a great tool.
nem2-sdk-java is an open source project and we love to receive contributions from our community — you! There are many ways to contribute, from writing tutorials or blog posts, improving the documentation, submitting bug reports and feature requests or writing code which can be incorporated into nem2-sdk-java itself.
Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue, assessing changes, and helping you finalize your pull requests.
Please, don't use the issue tracker for support questions.
If you think you have found a bug in nem2-sdk-java, first make sure that you are testing against the latest version of nem2-sdk-java - your issue may already have been fixed. If not, search our issues list on GitHub in case a similar issue has already been opened.
It is very helpful if you can prepare a reproduction of the bug. In other words, provide a small test case which we can run to confirm your bug. It makes it easier to find the problem and to fix it.
Please, take in consideration the next template to report your issue:
Expected Behaviour
Short and expressive sentence explaining what the code should do.
Current Behaviour
A short sentence enplaning what the code does.
Steps to reproduce
For faster issue detection, we would need a step by step description do reproduce the issue.
Provide as much information as you can.
Open a new issue here.
If you find yourself wishing for a feature that doesn't exist in nem2-sdk-java, you are probably not alone. There are bound to be others out there with similar needs. Many of the features that nem2-sdk-java has today have been added because our users saw the need. Open an issue on our issues list on GitHub which describes the feature you would like to see, why you need it, and how it should work.
If you have a bugfix or new feature that you would like to contribute to nem2-sdk-java, please find or open an issue about it first. Talk about what you would like to do. It may be that somebody is already working on it, or that there are particular issues that you should know about before implementing the change.
We enjoy working with contributors to get their code accepted. There are many approaches to fixing a problem and it is important to find the best approach before writing too much code.
This SDK project applies modified Google Code Style with all indentations set to 4 spaces.
IntelliJ users can find the code style import xml from resources/GoogleStyle_IntelliJ.xml
When you contribute code, you affirm that the contribution is your original work and that you license the work to the project under the project's open source license.
Whether or not you state this explicitly, by submitting any copyrighted material via pull request, email, or other means you agree to license the material under the project's open source license and warrant that you have the legal authority to do so.
You will need to fork the main nem2-sdk-java code or documentation repository and clone it to your local machine. See github help page for help.
Further instructions for specific projects are given below.
Once your changes and tests are ready to submit for review:
-
Test your changes
Run the test suite to make sure that nothing is broken.
-
Submit a pull request
Push your local changes to your forked copy of the repository and submit a pull request. In the pull request, choose a title which sums up the changes that you have made, and in the body provide more details about what your changes do. Also mention the number of the issue where discussion has taken place, eg "Closes #123".
Then sit back and wait. There will probably be discussion about the pull request and, if any changes are needed, we would love to work with you to get your pull request merged into nem2-sdk-java.
CONTRIBUTING.md is based on CONTRIBUTING-template.md , elasticsearch/CONTRIBUTING and spark/CONTRIBUTING