Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

support for S3 object store #5

Open
aleks-mariusz opened this issue Jun 20, 2019 · 5 comments
Open

support for S3 object store #5

aleks-mariusz opened this issue Jun 20, 2019 · 5 comments

Comments

@aleks-mariusz
Copy link

aleks-mariusz commented Jun 20, 2019

It seems to me that this project only supports google's object store..

is there a technical reason for this, or does the author simply not have access to/interest of an S3-compatible object store to test/implement this (i.e, something like Minio would work, I'd imagine).

I'm considering rolling out this set of nexus-related containers at our org's kubernetes cluster, but the lack of s3 support is a bit of a non-starter for us as we're fairly invested in S3 as a cloud storage/backup target.

So rather than simply complain, i could look into implementing this myuself. However first, would a PR to support S3 even be something of interest to the org/maintainers of this project?

I'd imagine it would just involve something like a.) install boto (to provide the aws s3 utility), b.) update the entrypoint script to use that utility instead of gsutil depending on the bucket URI prefix.. and c.) test test test the heck out of it manually before submitting said PR

Please let me know however if there's no interest in having this functionailty (such as for support reasons), so as to save me the time of doing this work (as i can perhaps just create our own fork within our org if the travelaudience devs don't want to own this going forward).

@varditn
Copy link
Contributor

varditn commented Jul 29, 2019

Hi @aleks-mariusz ,
The need for S3 backup support seems to exist in the market, I have seen it also on Nexus public helm chart.
We are working with GCP bucket for backup but there is a demand for S3 that we would like to comply with. So If you are willing to develop and test this change we will be happy to incorporate it in the image, as long as it is not a drastic image size change.

Please let me know if I can be of any assistant.

@LeoQuote
Copy link

plus one for this, I'm working on it

@LeoQuote
Copy link

I'm considering using rclone to do the whole backup job, rclone support tons of cloud storage, we it can save a lot of developing time

@JoshuaJackson-jobvite
Copy link

JoshuaJackson-jobvite commented Nov 25, 2019

@TAvardit what do you consider a drastic image size change? Doing a test of just installing aws cli into the existing image it looks like it goes from:

quay.io/travelaudience/docker-nexus-backup 1.5.0 f2c16a2754db 4 months ago 206MB

docker-nexus-backup latest 593fe7361153 5 seconds ago 536MB

largely..won't be able to say get that down a ton from there, due to python dependencies needing to be installed for the cli utilities.

@LeoQuote rclone is interesting, but requires some looks like large reconfiguration for anyone across the board, adding the aws cli utilities grows it a decent bit, but would support the two main clouds.

@dene14
Copy link

dene14 commented Dec 8, 2020

There is a fork with RClone: https://github.com/dbccompany/docker-nexus-backup
Docker hub: https://hub.docker.com/r/dbcc/docker-nexus-backup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants