Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Allow to specify additional const labels #7

Open
grzesuav opened this issue Jul 26, 2021 · 0 comments · May be fixed by #8
Open

feature: Allow to specify additional const labels #7

grzesuav opened this issue Jul 26, 2021 · 0 comments · May be fixed by #8

Comments

@grzesuav
Copy link

Expected Behaviour

I have two clients connecting to the same recipient, I would like to differentiate them.

I would like that httpClient.ForRecipient(url) will have version with additional map argument, when I can pass additional const labels, i.e.:

  • ForRecipient(recipient string, constLabels map[string]string)
  • ForRecepient(constLabels map[string]string)

Actual Behaviour

Currently when I want to call httpClient.ForRecipient(url) twice, it throws error that metrics are registered
grzesuav added a commit to grzesuav/go-promhttp that referenced this issue Jul 26, 2021
@grzesuav
feat: travelaudience#7 - Create instrumented client with more than on…
bd09058 
…e const label
grzesuav added a commit to grzesuav/go-promhttp that referenced this issue Jul 26, 2021
@grzesuav
feat: travelaudience#7 - Create instrumented client with more than on…
2a74a26 
…e const label

Signed-off-by: grzesuav <grzesuav@gmail.com>
@grzesuav grzesuav linked a pull request Jul 26, 2021 that will close this issue
Open
grzesuav added a commit to grzesuav/go-promhttp that referenced this issue Jul 26, 2021
@grzesuav
feat: travelaudience#7 - Create instrumented client with more than on…
eea403f 
…e const label

Signed-off-by: grzesuav <grzesuav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #7 - Create instrumented client with more than one const label grzesuav/go-promhttp
1 participant
@grzesuav