Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set object-store last-modified time as mtime in lakeFSFS direct access #8388

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arielshaqed
Copy link
Contributor

(This is not possible with presigned URLs, so obviously not done there.)

Closes #8339.

(This is _not_ possible with presigned URLs, so obviously not done there.)
@arielshaqed arielshaqed marked this pull request as draft November 21, 2024 09:28
Copy link

E2E Test Results - Quickstart

10 passed, 1 failed

Test failures:
  Quickstart › pull requests: common/quickstart.spec.ts

quickstart.spec.ts:102:9 pull requests

[quickstart] › common/quickstart.spec.ts:102:9 › Quickstart › pull requests ──────────────────────

Test timeout of 30000ms exceeded.

Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
  - waiting for locator('#pulls-tabs-tab-closed')


   at poms/pullsPage.ts:44

  42 |
  43 |     async gotoPullsTab(id: string): Promise<void> {
> 44 |         await this.page.locator(`#pulls-tabs-tab-${id}`).click();
     |                                                          ^
  45 |     }
  46 |
  47 |     async getFirstPullsRowDetails(): Promise<{title: string, description: string}> {

    at PullsPage.gotoPullsTab (/home/runner/work/lakeFS/lakeFS/webui/test/e2e/poms/pullsPage.ts:44:58)
    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/quickstart.spec.ts:142:25

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-quickstart-Quickstart-pull-requests-quickstart/trace.zip
Usage:

    npx playwright show-trace test-results/common-quickstart-Quickstart-pull-requests-quickstart/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lakeFSFS: Set mtime from backing store on lakeFS when using direct access
1 participant